libpod: make conmon always log to syslog #18887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conmon very early dups the std streams with /dev/null, therefore all errors it reports go nowhere. When you run podman with debug level we set --syslog and we can see the error in the journal. This should be the default. We have a lot of weird failures in CI that could be caused by conmon and we have access to the journal in the cirrus tasks so that should make debugging much easier. Conmon still uses the same logging level as podman so it will not spam the journal and only log warning and errors by default. [NO NEW TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
|
LGTM |
Member
Author
|
merge me |
Member
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conmon very early dups the std streams with /dev/null, therefore all errors it reports go nowhere. When you run podman with debug level we set --syslog and we can see the error in the journal. This should be the default. We have a lot of weird failures in CI that could be caused by conmon and we have access to the journal in the cirrus tasks so that should make debugging much easier.
Conmon still uses the same logging level as podman so it will not spam the journal and only log warning and errors by default.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?