Skip to content

Added promise rejection to chatgpt.getChatDetails()#65

Merged
adamlui merged 8 commits intoKudoAI:mainfrom
madkarmaa:main
Jul 10, 2023
Merged

Added promise rejection to chatgpt.getChatDetails()#65
adamlui merged 8 commits intoKudoAI:mainfrom
madkarmaa:main

Conversation

@madkarmaa
Copy link
Member

No description provided.

@madkarmaa
Copy link
Member Author

I've added reject because if the user has no chats, the whole function fails with an unhandled error

@madkarmaa
Copy link
Member Author

@adamlui what exactly you want me to add/fix?

@madkarmaa
Copy link
Member Author

except for the docs, I'll make a commit to userguide.md once the method is completed

@adamlui
Copy link
Member

adamlui commented Jul 10, 2023

@adamlui what exactly you want me to add/fix?

the logic you described in the last pr details

image

image

(but with the right sub-obj)

@madkarmaa
Copy link
Member Author

I don't know how you can work with stuff in light mode, I personally can't 💀

@adamlui
Copy link
Member

adamlui commented Jul 10, 2023

Some sites dark mode like GitHub really don't work for me, also there's no rush since the method is minimally viable already, you can add it as a task if I enable the Projects tab and you can get familiar with project management if you want, lmk and I'll activate it

@adamlui adamlui changed the title Still working on getChatDetails Added promise rejection to chatgpt.getChatDetails() Jul 10, 2023
@adamlui adamlui merged commit 9b2151c into KudoAI:main Jul 10, 2023
adamlui added a commit that referenced this pull request Jul 10, 2023
Added promise rejection to `chatgpt.getChatDetails()` ↄ1�7 [auto-sync from `kudoai/chatgpt.js`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants