New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keyboard focus styles #3011
Conversation
|
Thank you for your PR! While reviewing it, I've noticed that the Dashboard Card outlines did not work. The issue was that the I went ahead and updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before:
Screenshot.2023-07-24.at.16.41.56.mp4
After:
Description
The Admin site does not currently have any kind of keyboard focus styles, meaning that tabbing through elements on a page may prove to be difficult for some users.
This PR aims to resolve that by adding keyboard focus styles for a majority of the components, as well as provides a couple incredibly minor bugfixes related to tab-based navigation:
Paginator/ClickableArrowby setting thedisabledHTML attribute on itCopyToClipboarduses internallyFor users that do not use a keyboard to navigate the site, there is no perceivable change, as this approach utilizes the
:focus-visibleCSS pseudo-selector.While it is more of a minor accessibility fix, this change relates to #1232
Type of change