Add editorconfig #997
Merged
Add editorconfig #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Oct 13, 2017
I don't see why this can't be added.
Add the file to .gitattributes so it won't be exported with the releases. If not, I'll just do that later.
| insert_final_newline = true | ||
| indent_style = space | ||
| indent_size = 4 | ||
| trim_trailing_whitespace = true |
There was a problem hiding this comment.
Add a trailing newline at the end of the file here... which this very same config seems to enable.
There was a problem hiding this comment.
hah yes I didn't have an editorconfig file when I created the file
There was a problem hiding this comment.
Opening and re-saving the file, it automatically inserted it for me though.
w0rp
approved these changes
Oct 14, 2017
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
editorconfig is a great way to set some file formatting conventions for a project and have your text editor automatically apply them. This saves the hassle of having to fix and re-review pull requests because of simple indentation issues or Windows-created files with CRLF line endings.