Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for malfunctioning CI/tests. #150

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Fix for malfunctioning CI/tests. #150

merged 2 commits into from
Mar 16, 2021

Conversation

butuzov
Copy link
Contributor

@butuzov butuzov commented Mar 14, 2021

  • tests: failing tests (tests037) fixed.

  • tests: added subtests, so tests can be run separately.

  • ci: coveralls using go list ./... and tests with filtering out unneeded

  • ci: verbose test

  • ci: order of the CI steps changed

  • cov to lcov sep is hacky as original action works a bit weird, but I will fix it once find the reason for weird messages in CI.

@googlebot googlebot added the cla: yes Contributor signed Google CLA label Mar 14, 2021
@coveralls
Copy link

coveralls commented Mar 14, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 95.525% when pulling 92edaeb on butuzov:tests into 70c086a on cweill:develop.

@butuzov
fix(tests): fix for malfunctioning ci/tests
b993874 
* tests: failing tests (tests037) fixed.
* tests: added subtests, so tests can be run separatly.
* ci: coveralls using `go list ./...` and tests with filtering out unneeded
* ci: verbose test
* ci: order of the CI steps changed
@butuzov
Copy link
Contributor Author

butuzov commented Mar 14, 2021

Also, address #136

As for regarding coverals, ... it was supposed to consume report from coverals step (Runs on go 1.16)...

PASS
coverage: 96.1% of statements in github.com/cweill/gotests, github.com/cweill/gotests/internal/goparser, github.com/cweill/gotests/internal/input, github.com/cweill/gotests/internal/models, github.com/cweill/gotests/internal/output, github.com/cweill/gotests/internal/render

This was referenced Mar 15, 2021
Closed
Merged
@cweill cweill self-requested a review March 16, 2021 01:02
@cweill cweill changed the title fix(tests): fix for malfunctioning ci/tests Fix for malfunctioning CI/tests Mar 16, 2021
@cweill cweill changed the title Fix for malfunctioning CI/tests Fix for malfunctioning CI/tests. Mar 16, 2021
@cweill
Copy link
Owner

cweill commented Mar 16, 2021

Good work @butuzov. Thank you! LGTM.

@cweill cweill merged commit 44f58ed into cweill:develop Mar 16, 2021
@cweill cweill mentioned this pull request Mar 16, 2021
Closed
@butuzov butuzov deleted the tests branch March 28, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweill cweill cweill approved these changes

Assignees

@butuzov butuzov

Labels
cla: yes Contributor signed Google CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@butuzov @coveralls @cweill @googlebot