Skip to content

Revert "fall back to vanilla if xformers is not available (#51)"#61

Merged
jenuk merged 1 commit intomainfrom
revert-51-diffusion-attn-fallback
Jul 26, 2023
Merged

Revert "fall back to vanilla if xformers is not available (#51)"#61
jenuk merged 1 commit intomainfrom
revert-51-diffusion-attn-fallback

Conversation

@timudk
Copy link
Contributor

@timudk timudk commented Jul 25, 2023

This reverts commit ef520df.

@akx this is a good suggestion but has to be tested further internally.

@akx
Copy link
Contributor

akx commented Jul 25, 2023

@timudk It works fine on my Mac at least (see #60 for proof), and it will in any case raise a warning - the other option is that SDXL 0.9 simply doesn't work when xformers isn't available.

Also, by having it here in the open-source repo you'll have more people testing it. :)

@timudk
Copy link
Contributor Author

timudk commented Jul 25, 2023

@akx those are good suggestions but we would like to test them internally first.

@akx
Copy link
Contributor

akx commented Jul 25, 2023

Well, testing won't probably happen if the code isn't in the repo 😁

Again, this only makes things actually work when xformers isn't installed.

@jenuk jenuk merged commit a4ceca6 into main Jul 26, 2023
@benjaminaubin benjaminaubin deleted the revert-51-diffusion-attn-fallback branch July 26, 2023 10:10
LinearFalcon pushed a commit to LinearFalcon/generative-models that referenced this pull request Jul 6, 2024
SevanBrodjian pushed a commit to SevanBrodjian/sd-latent-exploration that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants