Skip to content

feat: add brave to core#12814

Merged
AlbumenJ merged 1 commit intoapache:3.3from
conghuhu:brave
Aug 14, 2023
Merged

feat: add brave to core#12814
AlbumenJ merged 1 commit intoapache:3.3from
conghuhu:brave

Conversation

@conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Jul 30, 2023

What is the purpose of the change

Implementing Brave in Dubbo Tracing.

Users can currently use starter or dubbo-tracing.

Brief changelog

Verifying this change

dubbo.tracing.enabled=true
dubbo.tracing.sampling.probability=1.0
dubbo.tracing.tracingExporter.zipkinConfig.endpoint=http://localhost:9411/api/v2/spans
dubbo.tracing.tracingExporter.zipkinConfig.connectTimeout=5s
<dependency>
  <groupId>org.apache.dubbo</groupId>
  <artifactId>dubbo-tracing</artifactId>
</dependency>
<!-- Opentelemetry as Tracer -->
  <dependency>
  <groupId>io.micrometer</groupId>
  <artifactId>micrometer-tracing-bridge-brave</artifactId>
</dependency>
<!-- Zipkin as exporter -->
<dependency>
  <groupId>io.zipkin.reporter2</groupId>
  <artifactId>zipkin-reporter-brave</artifactId>
</dependency>
<dependency>
  <groupId>io.zipkin.reporter2</groupId>
  <artifactId>zipkin-sender-urlconnection</artifactId>
</dependency>
2179f9800079277f061c94666549b9c

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@conghuhu
Copy link
Contributor Author

@AlbumenJ @songxiaosheng PTAL

@codecov-commenter
Copy link

Codecov Report

Merging #12814 (10fb8b3) into 3.3 (5ae875d) will increase coverage by 2.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.3   #12814      +/-   ##
============================================
+ Coverage     65.81%   68.21%   +2.40%     
  Complexity        6        6              
============================================
  Files          1843     1712     -131     
  Lines         73722    70433    -3289     
  Branches      10465    10219     -246     
============================================
- Hits          48517    48046     -471     
+ Misses        20489    17726    -2763     
+ Partials       4716     4661      -55     

see 173 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

79.4% 79.4% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 629bee3 into apache:3.3 Aug 14, 2023
@conghuhu conghuhu deleted the brave branch August 14, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants