Skip to content

Comments

fix(@angular/cli): fix typo in cli.ts#25609

Closed
eltociear wants to merge 2 commits intoangular:mainfrom
eltociear:patch-1
Closed

fix(@angular/cli): fix typo in cli.ts#25609
eltociear wants to merge 2 commits intoangular:mainfrom
eltociear:patch-1

Conversation

@eltociear
Copy link

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

numberic -> numeric

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contibution. Can you please update the commit message type from fix to docs?

@JeanMeche
Copy link
Member

JeanMeche commented Aug 26, 2023

Can you please drop that merge commit and rebase on main instead ? (and reword it per Alan)

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 29, 2023
@alan-agius4
Copy link
Collaborator

Closing as this PR is stalled. If you wish to land these changes, please re-open.

@alan-agius4 alan-agius4 closed this Sep 8, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants