Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeflow): disable codeflow on issues #26530

Merged
merged 2 commits into from Jan 5, 2023
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Dec 22, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Configuration

What is the current behavior?

Currently we do not use Codeflow. Codeflow would enable us to quickly run, test and verify changes on pull requests, without having to checkout different branches and re-run the Stencil app locally.

By default, once installed, the Codeflow bot will comment on both issues and pull requests. The value of commenting on issues is to have a quick environment to verify against the latest, but that is out of scope at the moment.

Additional information around Codeflow: https://developer.stackblitz.com/codeflow/integrating-codeflowapp-bot

What is the new behavior?

This is a prerequisite to installing the Codeflow bot for the repository.

  • Preparation for adding Codeflow to each pull request (comments a url to be able to run the changes locally, without having to manually clone)
  • Disables the Codeflow bot from commenting on issues at this time

Does this introduce a breaking change?

  • Yes
  • No

Other information

After this PR is merged we will need to visit: https://stackblitz.com/install-github-app and install the bot.

@sean-perkins sean-perkins marked this pull request as ready for review January 5, 2023 16:54
@sean-perkins sean-perkins requested a review from a team as a code owner January 5, 2023 16:54
@sean-perkins sean-perkins merged commit dd71a3b into main Jan 5, 2023
43 checks passed
@sean-perkins sean-perkins deleted the chore/codeflow branch January 5, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants