Fix average download speed (httpie#1516)#1518
Closed
mikurei wants to merge 1 commit intohttpie:masterfrom
mikurei:fix_avg_download_speed
Closed
Fix average download speed (httpie#1516)#1518mikurei wants to merge 1 commit intohttpie:masterfrom mikurei:fix_avg_download_speed
mikurei wants to merge 1 commit intohttpie:masterfrom
mikurei:fix_avg_download_speed
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1518 +/- ##
==========================================
- Coverage 97.28% 94.26% -3.02%
==========================================
Files 67 113 +46
Lines 4235 7696 +3461
==========================================
+ Hits 4120 7255 +3135
- Misses 115 441 +326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
DownloadStatusis finished, it callsProgressDisplay.stop(), which in turn callsProgressDisplay._print_summary()Here, in
_print_summary(), we incorrectly assume thattask.completedmeans observed steps, but in fact, when the download finishes, it is equal totask.total, which leads to issue with incorrect average download speed - no matter where we resume the download process, we always gettask.totalstepsSolution
ProgressDisplayclass by adding aresumed_atattribute to keep track of the progress that has already been done.ProgressDisplay.stop()method to passtask.completed - self.resumed_atinstead oftask.completedRelated
Solves the issue #1516