Skip to content

Add "Dockerfile" workflow running Hadolint#104

Closed
szepeviktor wants to merge 3 commits intobrefphp:mainfrom
szepeviktor:szepeviktor-patch-1
Closed

Add "Dockerfile" workflow running Hadolint#104
szepeviktor wants to merge 3 commits intobrefphp:mainfrom
szepeviktor:szepeviktor-patch-1

Conversation

@szepeviktor
Copy link
Copy Markdown

@szepeviktor szepeviktor commented Aug 6, 2023

This workflow will spot problems before Dockerfiles are used.

Warning

Hadolint is going to hurt your feelings!

source


BTW I name workflows based on the object (noun), not the action (verb).
So the viktoroid version of tests.yml would be images.yml or docker-images.yml - meaning "Build images and Test images"

@szepeviktor
Copy link
Copy Markdown
Author

szepeviktor commented Aug 6, 2023

If you are into OCI metadata: add this to .hadolint.yaml

# https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys
label-schema:
    org.opencontainers.image.created: "rfc3339"
    org.opencontainers.image.authors: "text"
    org.opencontainers.image.url: "url"
    org.opencontainers.image.documentation: "url"
    org.opencontainers.image.source: "url"
    org.opencontainers.image.version: "semver"
    org.opencontainers.image.revision: "hash"
    org.opencontainers.image.vendor: "text"
    org.opencontainers.image.licenses: "spdx"
    org.opencontainers.image.ref.name: "text"
    org.opencontainers.image.title: "text"
    org.opencontainers.image.description: "text"
    # org.opencontainers.image.base.digest: "text"
    # org.opencontainers.image.base.name: "text"

@szepeviktor szepeviktor changed the title Add "Docker" workflow running Hadolint Add "Dockerfile" workflow running Hadolint Aug 6, 2023
@mnapoli
Copy link
Copy Markdown
Member

mnapoli commented Aug 7, 2023

I don't understand this PR, sorry.

@szepeviktor
Copy link
Copy Markdown
Author

szepeviktor commented Aug 7, 2023

This PR adds a new workflow that run "Hadolint" on each commit.
Hadolint has dozens of rules to keep your Dockerfiles error-free on the long-term.

@szepeviktor
Copy link
Copy Markdown
Author

It is better to close this one.
Hadolint is still available to you.

@szepeviktor szepeviktor closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants