Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates CODEOWNERS with PD org changes #34

Merged
merged 2 commits into from Mar 6, 2023
Merged

Updates CODEOWNERS with PD org changes #34

merged 2 commits into from Mar 6, 2023

Conversation

alsmola
Copy link
Contributor

@alsmola alsmola commented Mar 2, 2023

No description provided.

@alsmola alsmola requested a review from a team March 2, 2023 00:15
jazanne
jazanne reviewed Mar 2, 2023
View reviewed changes
CODEOWNERS Outdated Show resolved Hide resolved
jazanne
jazanne requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@jazanne jazanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be accelerate team

@jazanne jazanne requested a review from zmdavis March 2, 2023 17:36
@zmdavis @jazanne
Update CODEOWNERS to more accurately reflect ownership
2188629 
Co-authored-by: Jaz White <jwhite@launchdarkly.com>
@zmdavis
Copy link
Contributor

zmdavis commented Mar 6, 2023

@alsmola We've updated the referenced team here, but it gives an error that says

make sure the team @launchdarkly/team-accelerate-product exists, is publicly visible, and has write access to the repository

That looks like the right team name, but maybe that team needs different permissions on this repo?

@alsmola alsmola merged commit 587c699 into main Mar 6, 2023
1 check passed
@alsmola alsmola deleted the SEC-3306-update-codeowners-new-pd-org branch March 6, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazanne jazanne jazanne requested changes

@zmdavis zmdavis Awaiting requested review from zmdavis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alsmola @zmdavis @jazanne