Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: make internal rst_stream errors retriable #699

Merged
igorbernstein2 merged 2 commits into from
Nov 18, 2022
Merged

fix: make internal rst_stream errors retriable #699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5273f34
fix: make internal rst_stream errors retriable
igorbernstein2 Nov 18, 2022
2798e8d
catch more rst stream variants
igorbernstein2 Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion google/cloud/bigtable/row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import copy
import time

import google.api_core.exceptions
import six

import grpc
Expand Down Expand Up @@ -507,7 +508,15 @@ def _read_next(self):
try:
return six.next(self.response_iterator)
except grpc.RpcError as grpc_error:
raise exceptions.from_grpc_error(grpc_error)
# TODO: this needs to be moved to a more general location (ie interceptor)
e = exceptions.from_grpc_error(grpc_error)
# Sometimes GOAWAYs are surfaced as INTERNAL errors, which makes
# them unretriable. This patches that behavior
if e.grpc_status_code == grpc.StatusCode.INTERNAL and (
"rst_stream" in e.message.lower() or "rst stream" in e.message.lower()
):
raise google.api_core.exceptions.ServiceUnavailable(e.message)
raise e

def _read_next_response(self):
"""Helper for :meth:`__iter__`."""
Expand Down