Gifting

[benthecarman]

Used for testing the gifting feature

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	97515a8
Status:	✅  Deploy successful!
Preview URL:	https://b9ffc7f8.mutiny-web.pages.dev
Branch Preview URL:	https://gifting.mutiny-web.pages.dev

View logs

[futurepaul]

needs MutinyWallet/mutiny-node#711 merged and then this is ready for review

[futurepaul]

things to test:
not enough funds on sender
too small amount for receiver (if it's a fresh wallet)
trying to redeem twice
loading from url
loading from scanner

[futurepaul]

rebase achieved, haven't re-tested yet. todo list here: #540

[benalleng]

When using the qr-scanner I am sent to this page
https://gifting.mutiny-web.pages.dev/gifting.mutiny-web.pages.dev

[futurepaul]

When using the qr-scanner I am sent to this page https://gifting.mutiny-web.pages.dev/gifting.mutiny-web.pages.dev

I think I fixed this, can't test right now though. (it was only a problem because I was looking for the string /gift and our staging url includes /gift because //gifting..

[AnthonyRonning]

This warning appears on the amount dialog for the gift amount editor. You should probably default to these types of warnings not being displayed so we quit running into it for anything besides the receive flow.

[AnthonyRonning]

1. The lightning fee warning is appearing but it wasn't needed. I redeemed 1 gift for 10k sats which opened up my first channel + 100k sats. Then I went to redeem a gift of 50k sats, which it warned I needed another channel for. This was incorrect.
2. Could the timeout warning be better here? In this case, I closed the browser on the gifter side but then redeemed on the receiver side. It should say that the gift is in progress becauase it sent the NWC message and it will be sent whenever the gifter comes back online.
3. There's nothing on the gifter side warning them that they need to be online for the gift to be redeemed.

[AnthonyRonning]

In general it's feeling pretty solid! Just a few edge cases and smaller feature requests. Nice work!

[benalleng]

Tested on firefox mobile web

• Not enough funds on sender error only happens on the receiver side (should probably check the available lightning balance at the time of gift creation)
• below 50k sats shows an appropriate warning on sender and an error on receiver side
• scanner and url both work as expected
• redeeming for a second time returns a "Payment timed out." no specific error that it had been redeemed already

[AnthonyRonning]

Should this feature be available to anyone that is self hosting?

[AnthonyRonning]

I hardcoded URL on both the sending and receiving side and as long as these match up properly, android works great. Even opens in app and/or scans in app properly. So just detecting android and switching URL should work.

[benthecarman]

Should this feature be available to anyone that is self hosting?

yeah it should

[futurepaul]

okay I think warnings are well behaved now and have a better error for timeout

also hardcoded urls

only comment I didn't get to is this one, didn't feel like it's 100% necessary

Not enough funds on sender error only happens on the receiver side (should probably check the available lightning balance at the time of gift creation)

[benthecarman]

ACK