Refactor Samsung devices install guide#7130
Refactor Samsung devices install guide#7130topjohnwu merged 2 commits intotopjohnwu:masterfrom salvogiangri:docs
Conversation
Signed-off-by: BlackMesa123 <giangrecosalvo9@gmail.com>
|
Not sure if everything for Samsung SAR+ should now be under a general "Samsung" heading... For example, are the extra wipes prescribed required for devices with launch versions less than Android 9? - I believe Vaultkeeper was only introduced with S10 series and A9... If devices with launch versions less than A9 are upgrading to A10+, they are converted from "legacy SAR" to modern "2SI ramdosk SAR" however... |
There's nothing specific to SAR+ devices in the Samsung guide, it can be used on legacy devices as well since the steps are exactly the same, tested myself on my old Galaxy S8+ running Android 9.
The two-steps bootloader unlock (RPMB) has been introduced since the S10 series with AVB 2.0 (iirc), on older devices you only have to enable "OEM unlocking" in Developer Options. However formatting the data partition is required the first time Magisk is installed if the device does have data encryption in place (both FDE or FBE) as I explained here.
KnoxGuard/RMM has been a thing in Samsung devices since 2018. The only thing you need to account is that the device is either not completely locked or temporarely locked, since the bootloader will refuse to load a custom kernel regardless of the bootloader lock state (you'll get the |
Signed-off-by: BlackMesa123 <giangrecosalvo9@gmail.com>
|
Does line 121 mean: |
I did copy back the original line I deleted in the first commit, so it's the same as before: Line 101 in 4856da1 Didn't apply any modification to it since it is correct. The OEM Unlock toggle will not be visible if these conditions aren't respected: @Override
public boolean isAvailable() {
return showEnableOemUnlockPreference(mContext) && // Device supports OEM unlocking
!KnoxGuardManager.getInstance().shouldBlockCustomRom() && // KG is not Prenormal, Active or Locked
mOemLockManager != null; // Device is not LDU or has eng firmware
}and will be grayed out if the bootloader has been unlocked in Download Mode: @Override
public void updateState(Preference preference) {
// ...
// KG is Prenormal, Active or Locked
// The toggle won't be visible anyway because this check is also in isAvailable()
if (KnoxGuardManager.getInstance().shouldBlockCustomRom()) {
mPreference.setEnabled(false);
} else {
mPreference.setEnabled(enableOemUnlockPreference()); // false if bootloader is unlocked
}
// ...
} |
|
Ah, that's clear, thanks... I don't have Sammy device to check but assume toggle does show enabled though greyed out... Still concerned about the wording if instructions are not just for 9+ Launch Version (SAR+) Samsung however... "Enable developer options, and confirm that the OEM unlocking option exists and is grayed out. This means the VaultKeeper service has unleashed the bootloader" would have applied to all SAR devices, and you do now refer to KnoxGuard which covers Android 7+ LV devices if I understand you comments linked above correctly... 👍 Guess 9+ devices with VaultKeeper retain KnoxGuard too, and toggle behaviour is the same then... I'm wondering if older devices get VaultKeeper or KnoxGuard with updates... Suspect it's LV dependant. Seems a note to cover old devices running A6 (some devices will only have stock ROMs up to A6 available) will be needed as KnoxGuard reference won't apply to these and wipes may be superfluous as well as caveats about unrooting etc... You'll know if older devices updated to A7+ are affected by KnoxGuard etc, or prone to bricking if images are restored to stock. Also, I know older devices had AP binary, but not all 4 binaries mentioned for SAR devices... 🙃 |
The fact the toggle is enabled while being grayed out is taken for granted since as I said in #7130 (comment) the toggle is grayed out when the bootloader is fully unlocked (it can't be disabled back if you first do not lock your bootloader again via Download mode).
The wording in the current guide are wrong, which is what I've fixed with my PR (other than adding how to identify if your device is locked). VaultKeeper is actually a security system service used to read/write data in the device's RPMB, which is then used by other system services such as KnoxGuard. KnoxGuard is the actual security feature that prevents flashing unsigned firmware images, and it also does more than that, you can check Samsung Knox documentation for more info. Older versions of this feature are named RMM (Remote Mobile Manager), the name is different but it's the exact same. Again, this has nothing to do with the device having SAR, but with the current running Android and Knox version the device is running on.
The main difference is that legacy devices might not have the "two-steps bootloader unlock" (devices shipped with Android 8 and below) or KG/RMM.
Not really an issue since legacy devices with one tar file can be patched without any issue. |
|
I am a little bit lost here. What is the correct way to root for example Samsung A51 which was already rooted before and I need to keep the data? (No wipe data) when Install/update official Samsung Firmware with Odin.
|
6 participants
close #7122