Rename react-server-dom-webpack entry points to /client and /server #25504
+81
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnoff
approved these changes
Oct 18, 2022
|
Yea, any change to fixtures triggers a lint to run on it which it shouldn't. Haven't figured out where the config needs to go yet. |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 19, 2022
Upgrade `react-server-dom-webpack` for exports renaming purpose x-ref: facebook/react#25504
Kikobeats
pushed a commit
to Kikobeats/next.js
that referenced
this pull request
Oct 24, 2022
Upgrade `react-server-dom-webpack` for exports renaming purpose x-ref: facebook/react#25504
gaearon
pushed a commit
that referenced
this pull request
Oct 24, 2022
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary In #25504, `react-server-dom-webpack/` was deprecated in favor of `react-server-dom-webpack/client`, but a remaining import wasn't adjusted accordingly. As a result, the remaining conditions within the file are no longer firing appropriately, which I ran into while playing around with a fork of [server-components-demo](https://github.com/reactjs/server-components-demo). The `index.js` file now contains a [placeholder](https://github.com/facebook/react/blob/main/packages/react-server-dom-webpack/index.js) and the actual logic of the client now sits in `/client`. ## How did you test this change? I replaced `require.resolve('../')` with `require.resolve('../client')` in the `react-server-dom-webpack` package in `node_modules` and confirmed that the output of the build looked good again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We called entry points
/writerinstead of/serverbecause "server" conflicted with the whole"react-server"naming convention. That was probably unnecessarily cute.Since then we added the
react-dom/cliententry point.I suspect we'll want to add a Hook or two that can be used by both server and client. E.g. useServerContextForRefetch. Which would go on
index.Since then we also got rid of the
.server.jsconvention.So I changed these:
react-server-dom-webpack/->react-server-dom-webpack/clientreact-server-dom-webpack/writer->react-server-dom-webpack/serverAdded an empty placeholder for:
react-server-dom-webpackThat way it lines up with the same convention in
react-dom.