refactor(@angular-devkit/architect): remove unneeded internal job input/output schema validation#26036
Closed
clydin wants to merge 1 commit intoangular:mainfrom
Closed
refactor(@angular-devkit/architect): remove unneeded internal job input/output schema validation#26036clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
clydin
force-pushed
the
architect/remove-extra-schema-val
branch
from
3a95649 to
e9a9fb1
Compare
…ut/output schema validation The internal job input and output value JSON schema-based validation has been removed for architect builder jobs. This validation was checking the internal architect jobs. However, these jobs and values are created by the internal implementation of architect and not by a builder's implementation. Actual builder option validation is unrelated to the validation change here. The JSON schema-based validation can be expensive and involves additional rxjs operator interaction within architect. Larger output results from a builder can be delayed significantly in some cases due to this unneeded validation.
clydin
force-pushed
the
architect/remove-extra-schema-val
branch
from
e9a9fb1 to
1e08235
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal job input and output value JSON schema-based validation has been removed for architect builder jobs. This validation was checking the internal architect jobs. However, these jobs and values are created by the internal implementation of architect and not by a builder's implementation. Actual builder option validation is unrelated to the validation change here. The JSON schema-based validation can be expensive and involves additional rxjs operator interaction within architect. Larger output results from a builder can be delayed significantly in some cases due to this unneeded validation.