MINOR: Add comment to onPartitionsLost override#14121
Merged
showuon merged 2 commits intoapache:trunkfrom Aug 11, 2023
Merged
Conversation
dajac
reviewed
Jul 28, 2023
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
force-pushed
the
examples-revoked
branch
from
1c9f6c9 to
714d622
Compare
fvaleri
changed the title
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
showuon
approved these changes
Jul 29, 2023
Member
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the improvement!
@fvaleri , one suggestion: I found you usually leave empty in the PR description, which is not good for reviewers. The PR description is the first place the reviewer will read before jumping into the code change. So if you can provide more info in the description, it'll make reviewer's job easier. I personally enjoy reviewing @divijvaidya 's PR a lot, because he explains everything clearly in the PR description. So you know what he is trying to achieve in the PR and which/why the method he chose...etc before jumping into the code. This PR is a good example. FYR!
Contributor
Author
|
Thanks @showuon, noted. |
Contributor
Author
|
@dajac are you good with these changes? |
Member
|
Failed tests are unrelated. |
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Aug 15, 2023
This adds comments to the ConsumerRebalanceListener overrides, in order to briefly explain why we are overriding these methods, when they are called, and what you can or can't do. Especially onPartitionsLost can create some confusion given the default implementation. Reviewers: Luke Chen <showuon@gmail.com>, David Jacot <djacot@confluent.io>
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Aug 15, 2023
This adds comments to the ConsumerRebalanceListener overrides, in order to briefly explain why we are overriding these methods, when they are called, and what you can or can't do. Especially onPartitionsLost can create some confusion given the default implementation. Reviewers: Luke Chen <showuon@gmail.com>, David Jacot <djacot@confluent.io>
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Aug 15, 2023
This adds comments to the ConsumerRebalanceListener overrides, in order to briefly explain why we are overriding these methods, when they are called, and what you can or can't do. Especially onPartitionsLost can create some confusion given the default implementation. Reviewers: Luke Chen <showuon@gmail.com>, David Jacot <djacot@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds comments to the ConsumerRebalanceListener overrides, in order to briefly explain why we are overriding these methods, when they are called, and what you can or can't do. Especially onPartitionsLost can create some confusion given the default implementation.