fix(metrics-extraction): Fix apdex resolution in on-demand#60537
Merged
fix(metrics-extraction): Fix apdex resolution in on-demand#60537
Conversation
Apdex was failing in Top N because it tries to build out top event conditions by resolving all fields. It's not necessary to check function fields since the data from top_events is a string -> data map, so a function will always fail regardless, and we don't want to build out conditions for functions regardless.
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #60537 +/- ##
==========================================
- Coverage 80.84% 80.84% -0.01%
==========================================
Files 5181 5181
Lines 227791 227791
Branches 38325 38326 +1
==========================================
- Hits 184163 184160 -3
Misses 38004 38004
- Partials 5624 5627 +3
|
armenzg
approved these changes
Nov 24, 2023
| for field in self.fields: | ||
| if fields.is_function(field): | ||
| # A function will never be in a top_events dict. | ||
| continue |
Member
There was a problem hiding this comment.
What a beautiful fix 😍 it makes me want to cry 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apdex was failing in Top N because it tries to build out top event conditions by resolving all fields. It's not necessary to check function fields since the data from top_events is a string -> data map, so a function will always fail regardless, and we don't want to build out conditions for functions regardless.