Simplify asset building #3459
Merged
Simplify asset building #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc60c31.
ukutaht
added
the
deploy-to-staging
|
Checking out the PR locally. Do setup instructions from |
aerosol
approved these changes
Nov 1, 2023
vinibrsl
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaces Webpack and PostCSS setup with esbuild and Tailwind CLI tools via their respective Elixir wrappers. The aim is to improve developer experience by speeding up asset builds in local development cycles. The new build system in general is simpler to manage and configure compared to webpack (IMO). Production artifacts (minified JS and CSS files) should be functionally equivalent to the previous webpack setup.
The setup is more or less copied verbatim from a project generated with
mix phx.new. It needed some adjustment for our setup, specifically multiple build targets for JS and the use of JSX/React. But if you squint it should look like a standard modern Phoenix setup.TODO: