Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: Add accept_traffic_until to "sites" #3627

Merged
merged 1 commit into from Dec 13, 2023
Merged

Migration: Add accept_traffic_until to "sites" #3627

merged 1 commit into from Dec 13, 2023

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Dec 13, 2023

Changes

We need to start dropping metrics for sites whose trial has expired or subscription was cancelled. The per-site timestamp gives us flexibility in treating each case separately.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@aerosol aerosol mentioned this pull request Dec 13, 2023
Merged
8 tasks
@aerosol aerosol requested a review from a team December 13, 2023 12:56
@aerosol aerosol merged commit 3f5eecf into master Dec 13, 2023
4 checks passed
@aerosol aerosol deleted the add-accept-metrics-until-migration branch December 13, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinibrsl vinibrsl vinibrsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aerosol @vinibrsl