Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote.push - how to know username/password is required and how to provide? #440

Open
barry-scott opened this issue May 23, 2016 · 6 comments
Open

Comments

@barry-scott
Copy link
Contributor

@barry-scott barry-scott commented May 23, 2016

It seems that I GitPython does not tell the caller that username/password are required by git.

Did I miss something in the API to do this?

Why does the call to remote.push fail with an error detailing the auth failure? I get a exit code 128.

I had to patch the source to print the git stderr to see why this failure happened.

@Byron
Copy link
Member

@Byron Byron commented May 25, 2016

Which version of GitPython are you using ? There has been a bug that could cause it to omit certain messages to stderr in the past.

Besides, as a general note, GitPython will do auth only without any user input. Usually this works by supplying a working ssh configuration, or by configuring GIT_SSH_COMMAND via the custom environment functionality of repo.git.

@barry-scott
Copy link
Contributor Author

@barry-scott barry-scott commented May 25, 2016

I'm creating a GUI that I hope can make it easier to use GIT.
To that end I do not want to have to require the user to any complex setup and the SSH stufff is
more complex then useing https for example.

I think the solution has to be to set GIT_ASKPASS to run a process that the parent process
can receive the credentials requests from via a pipe/socket. Then I can pop up a dialog to ask for
credentials and pass them to git (I could also save in a Wallet for later use).

Is this something you would add and support in GitPython?

@Byron
Copy link
Member

@Byron Byron commented May 26, 2016

Ah, interesting ! I think you should be able to set custom environment variables per call or for all calls on each repository's git instance. That way you can provide your own program to bring up some GUI to collect the login data for you as needed.

Regarding this issue: I wouldn't know what to do about it ... can you clarify ?

@barry-scott
Copy link
Contributor Author

@barry-scott barry-scott commented May 26, 2016

I think that you should consider handling the credentials side of GIT in the GitPython code.

For this it looks like you need a executable that you point GIT_ASKPASS at.
Before running GIT in a subprocess you would setup GIT_ASKPASS and open a
pair of unix domain sockets/Windows Named Pips to send and receive the data
from the program in GIT_ASKPASS.

That program will read its stdin and write that into GitPythons pipe. GitPython calls a
auth_callback with the details (username or password
and URL). The callback returns the answer and GitPython writes it into the pipe for
hte GIT_ASPPASS program to output on stdout.

Is that the clarification you wanted?

@Byron
Copy link
Member

@Byron Byron commented May 26, 2016

It seems this issue turned from a question and possibly a description of an issue (i.e. missing error description from git.push) into a specific feature request.

As to me GitPython is in maintenance mode and will only receive bugfixes or merges of suitable PRs, I flagged this issue as help wanted.

Maybe with you possibly implementing GIT_ASKPASS already, you might eventually see how the created code could integrate with GitPython to make it more useful to everyone.

@barry-scott
Copy link
Contributor Author

@barry-scott barry-scott commented May 29, 2016

I'll experiment with solution in git-workbench and when I have something useful I will create a PR for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.