-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove note that is contradicted in the subsequent paragraph #33268
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
@jmandel Thanks so much for opening a PR! I'll get this triaged for review ✨ |
|
Thanks for your contribution @jmandel ✨ |
This comment was marked as spam.
This comment was marked as spam.
|
@jmandel -I am not sure that there is a contradiction between both the note and the paragraph, but I agree that you've highlighted confusing content, that we should improve on. Thanks you so much for that 💖 ✨ |
|
Thanks! It sounds like I misunderstood the content. Here are some suggestions for how to make it clearer, @mchammer01.
If I understand correctly, this could be rewritten more clearly as something like
|
Why: remove contradictory information
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Remove a note stating that security reports cannot be made to repositories that do not opt into receiving them
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
datadirectory.For content changes, I have completed the self-review checklist.
The paragraph following the deleted line says that reports can be made to public repositories even if they have not turned on this feature.