Make PoolAcquireContext return a Connection type #578

Yrlish · 2020-05-20T15:47:18Z

__aenter__ in PoolAcquireContext should be defined to return a Connection type. This will help IDEs to properly help suggesting methods when using syntax:

with my_pool.acquire() as con:
  con  # this is now defined as type Connection by the acquire method
  pass

instead of doing this:

with my_pool.acquire() as con:  # type: Connection
  pass

Before:

After:


          Make PoolAcquireContext return a Connection type

`__aenter__` should be defined to return a `Connection` type. This will help IDEs to properly help suggesting methods when using with `pool.acquire() as con`

Yrlish · 2020-05-20T16:36:27Z

I forgot I have made an relevant issue 1.5 years ago #387.

elprans · 2020-07-18T16:26:30Z

There is a comprehensive effort to add type annotations in #577

MagicStack / asyncpg

Make PoolAcquireContext return a Connection type #578

Make PoolAcquireContext return a Connection type #578

Yrlish commented May 20, 2020 •

edited

Yrlish commented May 20, 2020 •

edited

elprans commented Jul 18, 2020

MagicStack / asyncpg

Join GitHub today

Make PoolAcquireContext return a Connection type #578

Make PoolAcquireContext return a Connection type #578

Conversation

Yrlish commented May 20, 2020 • edited

Yrlish commented May 20, 2020 • edited

elprans commented Jul 18, 2020

Essential cookies

Always active

Analytics cookies

Yrlish commented May 20, 2020 •

edited

Yrlish commented May 20, 2020 •

edited