kill_after_timeout watchdog is not able to kill the nested git processes #895

eekwong · 2019-07-17T00:52:16Z

I am using GitPython 2.0.2.

While having kill_after_timeout in the pull()
e.g. g.pull(kill_after_timeout=10)

Before the process killing, there were four processes running:

git pull
git fetch
git-remote-http
git fetch-pack

After the timeout, (3) and (4) remained.

Should _kill_process() be recursively called like the following?

                    if local_pid.isdigit():
                        _kill_process(local_pid) # is it necessary?
                        child_pids.append(int(local_pid))

Byron · 2019-07-21T00:26:01Z

Thanks a lot for sharing your findings!
Indeed, the way it kills the process is SIGKILL, which as far as I know can/will(?) leave child processes detached. So killing the entire process tree seems to be the right thing to do right now. In theory, making recursive calls could work.

Stray processes could be a real issue in long running processes :/.

Byron added acknowledged help wanted tag.leaks labels Jul 21, 2019

gitpython-developers / GitPython

kill_after_timeout watchdog is not able to kill the nested git processes #895

kill_after_timeout watchdog is not able to kill the nested git processes #895

eekwong commented Jul 17, 2019

Byron commented Jul 21, 2019 •

edited

gitpython-developers / GitPython

Join GitHub today

kill_after_timeout watchdog is not able to kill the nested git processes #895

kill_after_timeout watchdog is not able to kill the nested git processes #895

Comments

eekwong commented Jul 17, 2019

Byron commented Jul 21, 2019 • edited

Byron commented Jul 21, 2019 •

edited