-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rust: Add Postgres crate Models #18536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
geoffw0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great to have models for this SQL implementation.
|
The test failures:
I think these will go away if you merge
We're aware of this issue, it's a problem with the amount of data we're including in test outputs. I think @hvitved has an idea how to solve it. |
|
@geoffw0 it doesn't seem to have worked. The |
You can work around it by accepting the results from CI into your |
|
@geoffw0 Seems that worked! Let me know if you need any other changes before merging |
geoffw0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, all LGTM.
This PR is to add support for Postgres SQL Injection sinks
Requires this PR merging first:
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).