Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterLiveQueryEvent Triggers #773

Merged
merged 7 commits into from Nov 2, 2020
Merged

Conversation

@dblythy
Copy link
Contributor

@dblythy dblythy commented Oct 20, 2020

Docs for afterLiveQueryEvent. Awaiting the release of newest Parse Server version and possible merging of this PR.

@TomWFox would you see any benefit in adding a bit of text / examples around the LQ Triggers (beforeConnect / beforeSubscribe) in the LiveQuery security section?

Also, the Parse Server Guide has very little on enforcing security / validation in cloud code compared to the platform guides. Do you think it would be worth reiterating here as this is where I think most users would get started with Parse?

dblythy added 4 commits Oct 20, 2020
@dblythy dblythy marked this pull request as ready for review Oct 21, 2020
@TomWFox
Copy link
Member

@TomWFox TomWFox commented Oct 24, 2020

@TomWFox would you see any benefit in adding a bit of text / examples around the LQ Triggers (beforeConnect / beforeSubscribe) in the LiveQuery security section?

I think that would be beneficial, I wonder whether the security section could be pulled up a level so its more prominent but happy to follow your judgement on that.

It would be easier to maintain if it linked to the cloud code guide - perhaps with added security related examples there.

@TomWFox
Copy link
Member

@TomWFox TomWFox commented Oct 24, 2020

Also, the Parse Server Guide has very little on enforcing security / validation in cloud code compared to the platform guides. Do you think it would be worth reiterating here as this is where I think most users would get started with Parse?

Probably. There is a lot of overhauling needed in the Parse Server Guide generally. Again I think a bit of text with a link to the cloud code guide would be the best way to go in terms of maintainability but feel free to disagree...

Just thinking off the top of my head but I wonder whether the real improvement here would be to add the common security doc (included in all the client guides) to the server guide. What do you think?

Copy link
Member

@TomWFox TomWFox left a comment

Looks great, thanks for the PR!

_includes/cloudcode/cloud-code.md Outdated Show resolved Hide resolved
_includes/cloudcode/cloud-code.md Outdated Show resolved Hide resolved
@dblythy
Copy link
Contributor Author

@dblythy dblythy commented Oct 24, 2020

Thank you for your thoughts mate. I appreciate the time all the core team go to in relation to maintaining this great platform.

I think both are good suggestions. Personally, as a dev who learnt backend through Parse Server, I tend to think that there’s not enough reiteration around how important cloud validation of ACLs, queries, etc. When I started back in the parse.com days, I got the naive impression that parse was a backend that I didn’t have to worry about anything else. I think we could also have a security checklist (or maybe dashboard as related to this conversation on the forum).

@dblythy dblythy closed this Oct 24, 2020
@dblythy
Copy link
Contributor Author

@dblythy dblythy commented Oct 24, 2020

Oops wrong button

@dblythy dblythy reopened this Oct 24, 2020
@dblythy
Copy link
Contributor Author

@dblythy dblythy commented Oct 24, 2020

I will work through the security of the cloud docs @TomWFox and do my best to make the points as understood as possible, especially with all the new triggers (hopefully with my new PR for the validation handler too 😝). I’m also keen to work through any issue requests in this repo and close them out with PRs. If there’s anything else I could help make this amazing platform better, please let me know.

@TomWFox
Copy link
Member

@TomWFox TomWFox commented Oct 24, 2020

When I started back in the parse.com days, I got the naive impression that parse was a backend that I didn’t have to worry about anything else.

I can relate to this! There is definitely more we can do to to document security features & techniques.

You've been doing a fantastic job, the only thing I can say is keep the PRs rolling 😅

@dblythy
Copy link
Contributor Author

@dblythy dblythy commented Oct 25, 2020

Careful what you wish for @TomWFox 😂. I've got a few weeks spare thanks to COVID so I'll try to keep working on improvements for Parse Server that I've always wanted to make, but never understood how.

@dblythy dblythy requested a review from TomWFox Oct 25, 2020
Copy link
Member

@davimacedo davimacedo left a comment

It looks good to me. @TomWFox any additional comment?

@TomWFox TomWFox linked an issue that may be closed by this pull request Oct 26, 2020
@TomWFox TomWFox changed the title afterLiveQueryEvent Triggers (Pending Release) afterLiveQueryEvent Triggers Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants