Skip to content

Make bash window prompt adjuster more strict#210776

Merged
Tyriar merged 1 commit intomainfrom
tyriar/210773
Apr 19, 2024
Merged

Make bash window prompt adjuster more strict#210776
Tyriar merged 1 commit intomainfrom
tyriar/210773

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented Apr 19, 2024

Fixes #210773

@cpendery since you use git bash this might impact you. Are prompts in git bash apart from a simple $ common?

@Tyriar Tyriar added this to the April 2024 milestone Apr 19, 2024
@Tyriar Tyriar self-assigned this Apr 19, 2024
@Tyriar Tyriar merged commit a21b3e7 into main Apr 19, 2024
@Tyriar Tyriar deleted the tyriar/210773 branch April 19, 2024 18:22
@cpendery
Copy link
Copy Markdown
Member

@Tyriar, the $ is the default, but I have seen people customize them. I've been experimenting with sending over the prompt terminator, similar to how I sent the prompt height in #209136 and you sending the prompt continuation in #210615, to handle that, but it's not finished yet

@Tyriar
Copy link
Copy Markdown
Contributor Author

Tyriar commented Apr 19, 2024

Yeah was thinking about sending over the full prompt but there's probably lots of edge cases around escapes in it for each shell. Just the terminator is a pretty good idea.

Ive also been toying with the idea of learning what the prompt is over 3+ prompts, but the initial ones wouldn't benefit

sergioengineer pushed a commit to sergioengineer/VimSCode that referenced this pull request Apr 23, 2024
Make bash window prompt adjuster more strict
@microsoft microsoft locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pwsh starship prompt on Windows is often set wrong after ctrl+c

3 participants