feat: allow alphanumeric and alphabetic (lower, upper and mixed case) as configuration options for the characters used by the OTP #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2025 22:06
… as configuration options for the characters used by the OTP
Author
|
Hi auth team (@kangmingtay), I would love to get this feature (in this or a similar way) merged. So if there is anything I can do to support you with the review of this PR, feel free to poke me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds support for alphanumeric and alphabetic (lower, upper and mixed case) characters as configuration options for generating OTPs.
What is the current behavior?
OTPs can only be generated using digits.
What is the new behavior?
Users can configure whether OTPs should be generated using other characters than just digits.
Additional context
Background of this feature in this discussion: https://github.com/orgs/supabase/discussions/33744
I would love to get this feature (in this or a similar way) merged. So if there is anything I can do to support you with the review of this PR, feel free to poke me!