using php variable in javascript function

Question

My problem is I have a php variable $ba with a value of 147 retrieved from a DB the below snipets of my code does not work, no image is shown. If I add $ba=147; before the fill_div call it works perfectly. I am stumped as to why it dos'nt work when $ba populated from the DB. In both cases a check of the source code for the page shows the call being filled correctly fill_div("147");

<script type='text/javascript'>
    function fill_div(ba)
    {
        document.getElementById("ba").innerHTML="<img src='admin/images/image.gif'/>"; 
    }
</script>

<script>   
    fill_div("<? echo stripslashes($ba); ?>"); 
</script

<div id="<? echo $ba ?>" style="border:1px solid; width:120px; height:40px"></div>

If it's not populated from DB - how this question is related to HTML and javascript? — zerkms
– zerkms, Commented Sep 12, 2012 at 4:39
Please show the code where $ba is being declared. Is it inside of a function? Also, your javascript should be document.getElementById(ba); — cegfault
– cegfault, Commented Sep 12, 2012 at 4:44
removed quotes from getElementById(ba) did'nt make any differance — user1664457
– user1664457, Commented Sep 12, 2012 at 8:39
if $ba has a value of 127 and is set from a mysql_query it fails if I manualy set the value to 127 using $ba=127; or $ba="127"; right before the fill_div() call it works — user1664457
– user1664457, Commented Sep 13, 2012 at 0:47

Musa · Accepted Answer · 2012-09-12 04:51:03Z

4

You're passing the string literal"ba" to getElementById when you need to pass the variable ba

document.getElementById(ba).innerHTML="<img src='admin/images/image.gif'/>";

Also the stripslashes might not be a good idea if $ba has quotes in it, if $ba has a " in it will cause an error in your JavaScript if it is not escaped.

edited Sep 12, 2012 at 4:51

answered Sep 12, 2012 at 4:41

Musa

97.9k17 gold badges123 silver badges144 bronze badges

I added stripslashes on the off chance it may make a difference and the " have now been removed with same results

user1664457
– user1664457

09/12/2012 08:42:28
Commented Sep 12, 2012 at 8:42

Add a comment |

dnyan waychal · Accepted Answer · 2012-09-12 04:41:19Z

3

try ..

 document.getElementById(ba).innerHTML

answered Sep 12, 2012 at 4:41

dnyan waychal

4331 gold badge4 silver badges10 bronze badges

Add a comment |

xdazz · Accepted Answer · 2012-09-12 04:41:08Z

1

document.getElementById("ba")

should be

document.getElementById(ba)

answered Sep 12, 2012 at 4:41

xdazz

161k38 gold badges255 silver badges278 bronze badges

Add a comment |

the_red_baron · Accepted Answer · 2012-09-12 04:43:54Z

0

Try changing your document.getElementById to:

document.getElementById(ba)

If it has quotes (as in your example code) "ba" is treated as a string, not a variable.

answered Sep 12, 2012 at 4:43

the_red_baron

8887 silver badges14 bronze badges

thanks for your answer but even without the " still not working

user1664457
– user1664457

09/12/2012 08:45:20
Commented Sep 12, 2012 at 8:45

Add a comment |

Collectives™ on Stack Overflow

using php variable in javascript function

4 Answers 4

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Your Answer

Sign up or log in

Post as a guest

Related