Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrofit `repo` class as context-man to cleanup global mman on repo-delete #555

Merged
merged 4 commits into from Feb 25, 2017
Merged

Retrofit `repo` class as context-man to cleanup global mman on repo-delete #555

merged 4 commits into from Feb 25, 2017

Conversation

@ankostis
Copy link
Contributor

@ankostis ankostis commented Dec 8, 2016 •
edited

Some changes for this release:
See #553 for difficulties when working on Windows, where open file-handles actually "lock" the underlying files, and repos cannot be deleted.

More changes:

  • Small pythonism on #541, improves docstring of cmd._call_process().
  • Export gitpython.util.rmtree() for deleting repos in Windows where blobs are readonly.
ankostis added 4 commits Oct 28, 2016
@ankostis
fix(leaks): repo context-man to cleanup global mman on repo-delete
f1a82e4 
Improve API for problems like #553.
@ankostis
fix(leaks, TCs): attempt to cleanup mman before deleting tmp-dirs
bdb4c7c
@ankostis
feat(util): export rmtree() to facilitate del of tmp-repos on Windows
66306f1 
Usecase described in #553
@ankostis
style(cmd): pythonize cmd-args filtering for PY26, improve docstring
Loading status checks…
f858c44 
Apply codereview comments of #541.
@Byron Byron added the in progress label Dec 8, 2016
This was referenced Dec 8, 2016
Closed
Merged
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 8, 2016 •
edited

Current coverage is 94.50% (diff: 92.00%)

No coverage report found for master at 0691441.

Powered by Codecov. Last update 0691441...f858c44
@Byron
Copy link
Member

@Byron Byron commented Dec 8, 2016

@ankostis Do you think I should wait till tomorrow until I cut the release to be able to include this one? Or would you prefer to just have this released separately at a later time?
@Byron Byron modified the milestones: v2.1.1 - Bugfixes, v2.1.2 - Bugfixes Dec 8, 2016
@Byron
Copy link
Member

@Byron Byron commented Dec 8, 2016

@nvie I just created a new release.
@ankostis I will follow this PR and make a release when needed. Thanks to the Makefile, that became easy and convenient (interestingly, I wasn't aware it existed anymore :)).
@ankostis
Copy link
Contributor Author

@ankostis ankostis commented Dec 8, 2016

Sorry @Byron , I've just seen your message.

I'm not exactly sure what happened and you could not include my PR in 2.1.1.
I believe it ready to be merged.
is this right, or this PR relies on features from a different GitDB/smmap?
@Byron
Copy link
Member

@Byron Byron commented Dec 9, 2016

Even though the implementation seems to be in place, it would certainly be nice to include an example in the test_docs.py to show people how to use it. I for one wouldn't know myself actually, just because my experience with context managers is very limited.
Do you think you could add an example? I could then include it in the tutorial and write some prose around it :).
@ankostis
Copy link
Contributor Author

@ankostis ankostis commented Feb 5, 2017

Apologies for not having the time,
but I really believe this little PR wroth to have it.

Too overloaded to fix the TCs in the next weeks :-(
@Byron Byron merged commit 0181a40 into gitpython-developers:master Feb 25, 2017
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 92.00% of diff hit (target 94.50%)
Details
codecov/project 94.50% (+<.01%) compared to 2f207e0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Byron Byron removed the in progress label Feb 25, 2017
@Byron
Copy link
Member

@Byron Byron commented Feb 25, 2017

I think so too :)! Sorry for the incredible delays.
@ankostis ankostis deleted the ankostis:cntxtmman branch Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.3 - Bugfixes
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ankostis @codecov-io @Byron
You can’t perform that action at this time.