Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unittest code from non-test code #790

Open
mwatts15 opened this issue Aug 23, 2018 · 1 comment
Open

Remove unittest code from non-test code #790

mwatts15 opened this issue Aug 23, 2018 · 1 comment
Labels
acknowledged

Comments

@mwatts15
Copy link

@mwatts15 mwatts15 commented Aug 23, 2018

I see these imports of unittest in

I generally think that test code should not be built into the business logic. Is there a reason why using a skipIf decorator is insufficient?
@Byron Byron added the acknowledged label Oct 14, 2018
@Byron
Copy link
Member

@Byron Byron commented Oct 14, 2018 •
edited

Good catch, I absolutely agree! Even though I am pretty sure there was a very good reason to do that at some point in time. With the current state of windows test, for which these dependencies seemingly have been introduced. Maybe @ankostis can provide more context, who did magnificent work a while ago to get windows back into shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Byron @mwatts15
You can’t perform that action at this time.