Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitPython wheel includes "py2" in filename, but doesn't support Python 2 #898

Closed
toddmowen opened this issue Jul 22, 2019 · 5 comments
Closed

GitPython wheel includes "py2" in filename, but doesn't support Python 2 #898

toddmowen opened this issue Jul 22, 2019 · 5 comments
Assignees
@Byron
Labels
acknowledged
Milestone
v3.0.0 - Remove P...

Comments

@toddmowen
Copy link

@toddmowen toddmowen commented Jul 22, 2019

I'm not sure the proper conventions for using wheel to distribute packages, but the current artifact on PyPI is called GitPython-2.1.12-py2.py3-none-any.whl, implying support for Python 2. Although it's true that the "Meta" section on PyPI specifies Python >=3.0.

Is it possible to configure wheel to name it just with py3 instead?
@olivierlefloch
Copy link

@olivierlefloch olivierlefloch commented Jul 23, 2019 •
edited

2.1.12 specifies

Requires-Python: >=3.0, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*

2.1.11 specifies

Requires-Python: >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*

The changelog however does not mention removal of 2.7 support:

https://github.com/gitpython-developers/GitPython/blob/master/doc/source/changes.rst#2112---bugfixes-and-features

Python 2.7 support was dropped in #312

Perhaps doing this in a patch version was a bit heavy handed?
@stsewd
Copy link
Contributor

@stsewd stsewd commented Jul 27, 2019

BTW, python 2 support was kind of dropped in 2.1.11 7f08b77#diff-c276fc3c4df38382ec884e59657b869dR125 (when using a unicode branch/tag name that will fail)
@Byron
Copy link
Member

@Byron Byron commented Jul 29, 2019

@olivierlefloch I absolutely agree, and apologies, and I have just released v2.1.13 which returns python 2 support.

I am trying to cut a new release v3.0.0 which removes python 2 support, if I can manage to figure out all the places to edit to make that happen. For now I don't know how to turn off the py2. part in the whl filename, but I will keep trying 😅.
@Byron Byron added the acknowledged label Jul 29, 2019
@Byron Byron self-assigned this Jul 29, 2019
@dstine
Copy link

@dstine dstine commented Jul 29, 2019

@Byron
I did a quick experiment on the tip of master, and it appears that if you update setup.cfg to

[bdist_wheel]
universal=0

then the python tag will be just py3 instead of py2.py3 and the resulting wheel filename is GitPython-2.1.13-py3-none-any.whl. Assuming you are building with Python 3.

You would still want to update setup.py as you did before, to change python_requires and classifiers.
ghost pushed a commit that referenced this issue Aug 11, 2019
Sebastian Thiel
Avoid creating python 2 release
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
acbd5c0 
Thank you!
#898 (comment)

[skip CI]
@Byron Byron added this to the v3.0.0 - Remove Python 2 milestone Aug 11, 2019
@Byron
Copy link
Member

@Byron Byron commented Aug 11, 2019

Perfect, this works. Thanks so much, @dstine
@Byron Byron closed this Aug 11, 2019
@Harmon758 Harmon758 mentioned this issue Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Byron Byron

Labels
acknowledged
Projects
None yet
Milestone
v3.0.0 - Remove P...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@Byron @olivierlefloch @toddmowen @dstine @stsewd
You can’t perform that action at this time.