Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix encoding issue with stderr_value and kill_after_timeout #682
Conversation
We don't properly encode our error message under python3. Signed-off-by: Paul Belanger <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 61 61
Lines 10065 10065
=======================================
Hits 9356 9356
Misses 709 709
Continue to review full report at Codecov.
|
|
Thanks a lot for your contribution! |
openstack-gerrit
pushed a commit
to openstack-infra/zuul
that referenced
this pull request
Oct 10, 2017
Timeout remote git operations after 300 seconds. Because it could be in an invalid state, delete the local repo if a timeout occurs (subsequent operations will recreate it). This replaces our use of the clone_from() and fetch() methods from GitPython with lower-level equivalents. The high-level methods do not currently permit the hard timeout. The GitPython requirement is changed to a temporary fork until both gitpython-developers/GitPython#682 and gitpython-developers/GitPython#686 end up in a release. Change-Id: I7f680472a8d67ff2dbe7956a8585fb3714119e65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We don't properly encode our error message under python3.
Signed-off-by: Paul Belanger [email protected]