Skip to content

/ GitPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: Added missing NullHandler to logger in git.remote #666

Merged
merged 1 commit into from Sep 21, 2017
Merged

BF: Added missing NullHandler to logger in git.remote #666

merged 1 commit into from Sep 21, 2017

Conversation

@bpoldrack
Copy link
Contributor

@bpoldrack bpoldrack commented Aug 31, 2017

Stumbled upon a No handlers could be found for logger "git.remote" message.
Apparently this issue has been addressed in PR #300 already. Back then git/remote.py wasn't included, so here is a one liner to do so.
@bpoldrack bpoldrack mentioned this pull request Aug 31, 2017
Closed
@bpoldrack
BF: Added missing NullHandler to logger in git.remote
Verified
This commit was signed with a verified signature.
bpoldrack Benjamin Poldrack
GPG key ID: F5500AFA8C55CFEF Learn about signing commits
Loading status checks…
2b3c16c
@bpoldrack bpoldrack force-pushed the bpoldrack:bf-nullhandler branch from 5e11a68 to 2b3c16c Sep 21, 2017
@codecov-io
Copy link

@codecov-io codecov-io commented Sep 21, 2017 •
edited

Codecov Report

Merging #666 into master will increase coverage by 1.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #666     +/-   ##
=========================================
+ Coverage   92.57%   94.38%   +1.8%     
=========================================
  Files          61       61             
  Lines        9968     9970      +2     
=========================================
+ Hits         9228     9410    +182     
+ Misses        740      560    -180
Impacted Files Coverage Δ
git/test/test_remote.py 97.82% <0%> (ø) ⬆️
git/refs/remote.py 91.13% <0%> (+0.02%) ⬆️
git/compat.py 63.19% <0%> (+0.22%) ⬆️
git/refs/symbolic.py 96.5% <0%> (+0.31%) ⬆️
git/config.py 92.76% <0%> (+0.32%) ⬆️
git/test/test_submodule.py 99.22% <0%> (+0.38%) ⬆️
git/test/test_docs.py 100% <0%> (+0.39%) ⬆️
git/cmd.py 85.54% <0%> (+0.47%) ⬆️
git/repo/base.py 95.82% <0%> (+0.69%) ⬆️
git/exc.py 96.42% <0%> (+1.78%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8dc25...2b3c16c. Read the comment docs.
@yarikoptic yarikoptic merged commit 4bbaf1c into gitpython-developers:master Sep 21, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@bpoldrack @codecov-io @yarikoptic
You can’t perform that action at this time.