Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[bugfix] Bugfix embed_loader.py #128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=====================================
Coverage 68% 68%
=====================================
Files 90 90
Lines 6286 6286
=====================================
Hits 4275 4275
Misses 2011 2011
Continue to review full report at Codecov.
|
|
Could you please provide a small piece of glove that cause the bug as an example at here? As we haven't met such issue when using Glove. Thanks. |
Description:简要描述这次PR的内容
Bugfix embed_loader.py
Main reason: 做出这次修改的原因
Some lines in the glove file do not contain an embedded word. There're only embedding vectors in these lines. For these lines, len(line) equals to 'emb_dim', rather than 'emb_dim + 1'. Just setting 'if len(line) > 2' won't work for all the lines.
Checklist 检查下面各项是否完成
Please feel free to remove inapplicable items for your PR.
Changes: 逐项描述修改的内容
Mention: 找人review你的PR
@xuyige