current community

your communities

more stack exchange communities

company blog
Stack Exchange Inbox Reputation and Badges
tour help
Join the Stack Overflow Community
Stack Overflow is a community of 4.7 million programmers, just like you, helping each other.
Join them; it only takes a minute:
Sign up
up vote 0 down vote favorite

This is the first time to use angular js.

The following code gives desired output:

<a href="http://www.example.com/xyz/{{life.animal}}/" target="_blank">Hello </a>

It opens a page: http://www.example.com/xyz/cat/

But the below code is not working as expected:

<a href='javascript:void(0)' onClick='javascript:window.open("http://www.example.com/xyz/{{life.animal}}/","Windows","width=1150,height=450,toolbar=no,menubar=no,scrollbars=yes,resizable=yes,titlebar=no,location=no,directories=no,status=no");return false')'>Hello </a>

It opens page: http://www.example.com/xyz/{{life.animal}}/

I think I am doing some basic mistake but please help me.

share|improve this question
    
I used target="_blank" instead. Thanks all for the help. – ruchi Oct 8 at 21:22
up vote 2 down vote

The Angular scope is not available outside of Angular, i.e. vanilla JS.

To set a click function the angular way you should use ng-click

Create a function in your controller or directive such as

scope.open = function() { $window.open(...) }

In the template do

ng-click="open()"

share|improve this answer
up vote 1 down vote

angular doesn't interact with strings, but you try to do that in your onclick handler that opens a window (you pass a string there). Stop the string and concat with the variable:

onClick='javascript:window.open("http://www.example.com/xyz/" + life.animal)'

Also, as @Enzey has noted, use ng-click instead of onClick, and then bring out the javascript from your html and do that stuff in a controller instead.

E.g.:

HTML

<a href="javascript:void(0)" ng-click="myFunction()">Foo</a>

Controller

$scope.myFunction = function() {
    window.open(...whatever...);
}
share|improve this answer
    
Also, one should use an onclick event on the element, to open it on a popup window. Also, even better, is to use target="_blank" instead. – Ismael Miguel Oct 8 at 20:56
up vote 1 down vote

The double hash are used for angular directives not for Javascript Vanilla apart of that is better if you use ng-href instead href in a tag. You can check this here

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.