-
Notifications
You must be signed in to change notification settings - Fork 161
[master] feat: enable Fedora 42 packaging #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enables docker-ce builds for Fedora 42. This will be GA in a couple months, and like usual, has a lifespan of two years. The workarounds required for Go on ARM are still required on this version, so have been left in. The comments are still relevant. Signed-off-by: Robert Sturla <robertsturla@outlook.com>
nit: s/two years/one year/ |
Co-authored-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: Robert Sturla <robertsturla@outlook.com>
|
Here's the last few lines of the build output: |
|
Ah, looks like we don't build fedora in this CI, I think we can add it to https://github.com/docker/docker-ce-packaging/blob/master/.github/workflows/ci.yml#L25 so we can see it in the CI. |
I don't think that would work - they seem to be only Ubuntu builds there. thaJeztah typically takes the contents of this PR into their own, which enables the pipelines in Jenkins to run. I guess I can give it a go if you'd like |
Signed-off-by: Robert Sturla <robertsturla@outlook.com>
|
Hmm, interesting. I saw this: #1058 (comment) - it only mentions the Jenkins not running external contributors, but looks like the Jenkins job is running on this one 🤔 The GHA workflow shouldn't have that restriction though, so I think adding fedora the would still work. We can try! |
I believe the Jenkins pipeline which is running on this PR doesn't include the changes I have made, and is instead running from the Jenkinsfile on the main branch. I.E. Jenkins doesn't know about the Fedora 42 targets. I've pushed a new commit to build F42 inside GHA, and it looks like it is working. 0770878 |
|
Oh right. Well since the GHA passes, I don't think there should be any problem in Jenkins, but I can double-check that in a follow-up draft PR separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
|
Hey @vvoland Don't suppose you know when this will end up in the repos? https://download.docker.com/linux/fedora/42/x86_64/stable/Packages/ |
|
Hi, AFAIK we can't easily deploy new packages for already published Docker version. EDIT: Actually, let me double check. I might be able to redeploy 28.0.4 for the new arches only. |
|
@p2 We released v28.1.0-rc.1 with Fedora 42 packages: https://github.com/moby/moby/releases/tag/v28.1.0-rc.1 |
|
For now this folder here https://download.docker.com/linux/fedora/42/x86_64/stable/Packages/ contains only containerd. I don't know if there is any "sync" mechanism that has to run before we see the docker-ce packages. |
|
RCs are only available in the |
|
FYI, v28.1.0 was just released in the stable channel. |

Needs docker/containerd-packaging#408
- What I did
Enables docker-ce builds for Fedora 42. This will be GA in a couple months, and like usual, has a lifespan of one year.
The workarounds required for Go on ARM are still required on this version, so have been left in. The comments are still relevant.
- How I did it
- How to verify it
I ran a
make fedora-42, which currently fails due to a lack of containerd (I expect).- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)