Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception code property must be int - DriverException.php #229

Open
wants to merge 1 commit into
base: master
from

Conversation

@matak
Copy link

matak commented Apr 16, 2019

As PHP exception is defined with code of type int, there must be always int

public function __construct(string $message = "", int $code = 0, \Throwable $previous = NULL) {}

  • bug fix
  • BC break? no
As PHP exception is defined with code of type int, there must be always int

public function __construct(string $message = "", int $code = 0, \Throwable $previous = NULL) {}
@dg dg force-pushed the nette:master branch 2 times, most recently from 4c0e8d0 to e17242a Nov 13, 2019
@dg dg force-pushed the nette:master branch 6 times, most recently from f9fc19d to dd75e74 Dec 10, 2019
@dg dg force-pushed the nette:master branch 2 times, most recently from cce6a9c to 7e705c5 Dec 25, 2019
@dg dg force-pushed the nette:master branch 2 times, most recently from 9acf825 to a268c60 Mar 27, 2020
@dg dg force-pushed the nette:master branch from a268c60 to 4d5cb8f May 11, 2020
@dg dg force-pushed the nette:master branch 2 times, most recently from a56e7fe to d9b5f29 Jun 9, 2020
@dg dg force-pushed the nette:master branch 2 times, most recently from f016c33 to 6596c77 Jul 10, 2020
@dg dg force-pushed the nette:master branch from 6596c77 to 840858a Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.