[bazel] Upgrade some rulesets in preparation for enabling windows#11109
Merged
zbarsky-openai merged 1 commit intomainfrom Feb 8, 2026
Merged
[bazel] Upgrade some rulesets in preparation for enabling windows#11109zbarsky-openai merged 1 commit intomainfrom
zbarsky-openai merged 1 commit intomainfrom
Conversation
zbarsky-openai
force-pushed
the
zbarsky/windows-prep
branch
from
d3be18d to
039ba8a
Compare
zbarsky-openai
force-pushed
the
zbarsky/windows-prep
branch
from
039ba8a to
efa38ef
Compare
bolinfest
reviewed
Feb 8, 2026
|
|
||
| common:windows --strategy=TestRunner=local | ||
|
|
||
| # On windows we can not cross-build the tests but run them locally due to what appears to be a Bazel bug |
Collaborator
There was a problem hiding this comment.
Suggested change
| # On windows we can not cross-build the tests but run them locally due to what appears to be a Bazel bug | |
| # On windows we cannot cross-build the tests but run them locally due to what appears to be a Bazel bug |
bolinfest
reviewed
Feb 8, 2026
| proc_macro_dev_deps = all_crate_deps(proc_macro_dev = True) | ||
|
|
||
| test_env = { | ||
| "INSTA_REQUIRE_FULL_MATCH": "0", |
Contributor
Author
There was a problem hiding this comment.
stray change, reverting
bolinfest
reviewed
Feb 8, 2026
| extra_target_triples = RUST_TRIPLES, | ||
| versions = ["1.93.0"], | ||
| # TODO(zbarsky): bump to 1.93 after fixing mingw | ||
| version = "1.92.0", |
Collaborator
There was a problem hiding this comment.
How long will this take to fix? I worry about disagreement between lints that are new in 1.93.0, for example, though I guess we still have cargo builds to catch those today?
bolinfest
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.