up vote 1 down vote favorite

I'm changing the value in a multi-dimensional array and it's not staying outside of the foreach loop that's being used to traverse it.

My array initially looks something like this:

Array
{
  [0] => Array
   {
     [name] => Bob
     [age] => 33
     [state] => CA
     [visited] => 0
   }
   ...
}

My PHP gets into it by going:

foreach ($people as $person){
 echo $person['name']
 ....
 logic for the visited variable
 ...
 $person['visited'] = $calculated_visit_value;
}

If I 

print_r($person)

at the end (but inside) of the foreach loop everything looks good, the value for visited is set. However, if I print_r($people) outside of the loop, $person['visited'] is not set. I don't know what I'm doing wrong.

Help is appreciated.

share|improve this question
1  
your editing a copy of the array made by foreach (as $...) – Dagon Jul 19 '11 at 22:07

3 Answers

up vote 8 down vote

You are creating a new variable called $person from within that for loop and your array will never see the scope of that new variable.

You can try passing it by reference, like so: 

foreach ($people as &$person){
 echo $person['name'];
 ....
 logic for the visited variable
 ...
 $person['visited'] = $calculated_visit_value;
}
share|improve this answer
Yup that's it! Thank you. I need to wait 7 minutes to mark it as correct, but that worked perfectly. – mikepreble Jul 19 '11 at 22:13
up vote 0 down vote

The $person array is generated on each iteration, so setting that value would be overwritten on the next go through anyway.

But even so, that array only exists during the loop. You should create another array before the loop and put your values into that array during the loop.

share|improve this answer
up vote 0 down vote

From foreach's documentation:

Unless the array is referenced, foreach operates on a copy of the specified array and not the array itself. foreach has some side effects on the array pointer. Don't rely on the array pointer during or after the foreach without resetting it.

What this means is that your $person variable is a copy of what was in the array, similar in effect to this code (note that this code is for understanding only and wrong on many levels, in reality you would use the reset(), current() and next() function to loop properly over your array, see here):

for ($i = 0; $i < count($people); $i++) {
  $person = $people[$i];
  // code inside your foreach ...
}

So if you change the content of $person, you don't actually modify what's inside the $people array

To solve that, you can either use a referenced foreach:

foreach ($people as &$person) { // note the &
  $person = $calculated_visit_value; // $person is now a reference to the original value inside $people and thus this will work as intended
}

Note that the refence is not cleared when the foreach loop ends, so at the end of it $person is still a reference to the last element of $people. If you don't know what references are, please refer to the documentation for more info.

Or use the key to access the original array:

foreach ($people as $person_index => $person) {
  $people[$person_index] = $calculated_visit_value;
}

For your information, you can use the two together

foreach ($people as $person_index => &$person { ...
share|improve this answer

Your Answer

 
or
required, but never shown
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.