Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 9 down vote favorite
1

I am running into some serious memory leaks in my application, so I setup this extremely bare solution to test what happens when a String array goes out of scope...

I know that the old TextString implementation of String was lacking a destructor, but this current implementation seems to have it.

I am using this MemoryFree library (Note this linked code has now been fixed based on the accepted answer to this question).

The code examines two scenarios: Allocation of char array and string array in two different functions to force scope exit on both.

#include <MemoryFree.h>

void setup() {
  // put your setup code here, to run once:
  Serial.begin(9600);
  int freeBefore, freeAfter;

  //TEST ALLOCATION OF CHAR ARRAY//
  freeBefore = freeMemory();
  AllocateCharArr();
  freeAfter = freeMemory();
  Serial.println("CHAR*: Before " + String(freeBefore)
    + ", After " + String(freeAfter)
    + ", Diff " + String(freeBefore - freeAfter));

  //TEST ALLOCATION OF STRING//
  freeBefore = freeMemory();
  AllocateStringArr();
  freeAfter = freeMemory();
  Serial.println("STRING: Before " + String(freeBefore)
    + ", After " + String(freeAfter)
    + ", Diff " + String(freeBefore - freeAfter));
}

void AllocateCharArr() {
  char s[100];
}

void AllocateStringArr() {
  String s[100];
}

void loop() { /* empty */ }

Output:

CHAR*: Before 1710, After 1710, Diff 0
STRING: Before 1645, After 1309, Diff 336

How come the String array allocation is not wiped from memory?

share|improve this question
1  
What is the result when the String array is much smaller (e.g., 10 elements)? – ouah Jan 15 '12 at 23:34
Interesting: 50 elements=diff 136, 25 elements=diff 36, 10 elements=diff 0 – Silas Hansen Jan 16 '12 at 7:00
What version of the Arduino software are you using (0023, 1.0, ...)? – Matthew Murdoch Jan 16 '12 at 13:59
I'm using software version 1.0, running it on a Arduino UNO R3 board with ATmega328 controller. – Silas Hansen Jan 16 '12 at 18:35

3 Answers

up vote 4 down vote accepted

I have come across memory handling issues in Arduino versions prior to 1.0 when testing the String class (see forum post here).

The String constructor uses realloc internally and it's this (avr libc) dynamic memory handling that was causing the problems (due to the pointer to the top of the heap __brkval not being updated upon free()).

Run the following code to see these issues in versions 0023, 0022, etc. In Arduino 1.0 the code should show no memory leaks:

#if (ARDUINO >= 100)
#include <Arduino.h>
#else
#include <WProgram.h>
#endif
#include <HardwareSerial.h>
#include <MemoryFree.h>

void setup() {
  // put your setup code here, to run once:
  Serial.begin(9600);
  int freeBefore, freeAfter;

  freeBefore = freeMemory();

  void* buffer = malloc(10);
  if (buffer == 0) {
    Serial.println("Failed to allocate memory");
  }
  free(buffer);

  freeAfter = freeMemory();
  Serial.println("Before " + String(freeBefore)
    + ", After " + String(freeAfter)
    + ", Diff " + String(freeBefore - freeAfter));
}

void loop() {
}

In addition, the MemoryFree library you are using can give wrong results as it doesn't take into account the free list. Try this updated version of MemoryFree.cpp:

extern unsigned int __heap_start;
extern void *__brkval;

/*
 * The free list structure as maintained by the 
 * avr-libc memory allocation routines.
 */
struct __freelist {
  size_t sz;
  struct __freelist *nx;
};

/* The head of the free list structure */
extern struct __freelist *__flp;

#include "MemoryFree.h";

/* Calculates the size of the free list */
int freeListSize() {
  struct __freelist* current;
  int total = 0;

  for (current = __flp; current; current = current->nx) {
    total += 2; /* Add two bytes for the memory block's header  */
    total += (int) current->sz;
  }

  return total;
}

int freeMemory() {
  int free_memory;

  if ((int)__brkval == 0) {
    free_memory = ((int)&free_memory) - ((int)&__heap_start);
  } else {
    free_memory = ((int)&free_memory) - ((int)__brkval);
    free_memory += freeListSize();
  }
  return free_memory;
}
share|improve this answer
Thank you! It turned out it was the freeMemory function that reported bad values. Using your supplied method instead, gives correct results and no leak seems to occur. – Silas Hansen Jan 16 '12 at 19:00
Good to know the Arduino 1.0 libraries are OK. Will update the answer. Thanks! – Matthew Murdoch Jan 16 '12 at 19:40
I've updated the MemoryFree.cpp library code on the Arduino site (arduino.cc/playground/Code/AvailableMemory) in line with this accepted answer. – Matthew Murdoch Jan 16 '12 at 21:33
up vote 0 down vote

If you look through the Arduino source, you might come across the file ".\arduino-1.0\hardware\arduino\cores\arduino\WString.cpp". In this file, I noticed that String does not have a default (parameterless) constructor. Perhaps this could be the problem? Doubtful, but anyway, the source should help. Best of luck.

share|improve this answer
I've been looking into that file already, primarily to verify that it had a destructor. I will test to see if an array initialized with values makes any difference. – Silas Hansen Jan 16 '12 at 7:04
up vote 0 down vote

Comment out the line String s[100]; and see if you get different results. It looks like the memory allocations you're seeing are due to the string operations in your setup() function, not to the declaration of a local array of strings in AllocateStrArr(). You can take a look at WString.cpp and WString.h to see that operator+ has been overridden, so every call to String() or concatenation using + could create another object.

share|improve this answer
Commenting that line brings its to diff 0. – Silas Hansen Jan 16 '12 at 6:55

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.