Tell me more ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote -1 down vote favorite

I was wondering if I could get some constructive feedback on my coding. I've got a year left of school, then I'll graduate with a Bachelors in Multimedia and Web Design. I'm also interning with a start up web development llc. I'd like to hear some more diverse opinions on what I could do to improve my code and become more efficient. When I graduate, I would very much like to start a career in Front end development. I just started with jQuery and javascript and I have a lot to learn before I can ask for feedback on that.

Thank you in advance for your time! :) Here's a link to some of my code. https://github.com/AmandaFemGuitar

share|improve this question
2  
No offense, but the first paragraph of your question is unnecessary because knowing about your life doesn't help us review your code. Finally, please read the FAQ - you need 1) to post the code here 2) to tell us what kind of feedback you're looking for: code correctness, best practices and design pattern usage, application UI, security issues, etc. – Laurent May 23 '12 at 4:35
1  
According to the FAQ, please post the code to be reviewed. – ANeves May 23 '12 at 12:14
Laurent - whenever someone starts a comment with, "no offense," it's usually offensive. Yours was no exception. Knowing that I'm a student could help in the way someone approaches their review. Also knowing that I'm only interested in being a front-end developer, they don't need to advise me to learn anything back-end to improve. What you said after "Finally" was actually helpful, though. – antu May 23 '12 at 19:25

closed as off topic by Winston Ewert♦ May 23 '12 at 22:40

Questions on Code Review Stack Exchange are expected to relate to code review request within the scope defined in the FAQ. Consider editing the question or leaving comments for improvement if you believe the question can be reworded to fit within the scope. Read more about closed questions here.

1 Answer

up vote 1 down vote

Your projects on GitHub lack a description and a README. Coding is writing and documentation is an important part of software.

Here is a possible workflow:

  1. write a README to describe your project
  2. write unit tests and a simple example of what you expect the code to do
  3. write the code itself
  4. iterate with each new feature

On a side note:

  • do not mix tabs and spaces, which breaks indentation
  • avoid mixing HTML files and JavaScript files and CSS files and images in the same folder
  • for better maintenance and performance, favor external JavaScript files instead of inline JavaScript in HTML files
share|improve this answer
I would like to add: 1. Pick a consistent naming convention. 2. Check W3C required and recommended tag attributes. Some of your link tags are somewhat lacking. – Chris Frazier May 23 '12 at 12:48
Thank you, that's helpful. – antu May 23 '12 at 19:34

Not the answer you're looking for? Browse other questions tagged or ask your own question.