Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I have a script that's scraping images from a website (4chan). It's having to do it by getting the url from the anchor tags not the image, else it would only get the thumbnails. The problem is that the url for the image appears in two anchor tags, thus each image appears twice.

I've tried putting them into an array and then applying array_unique() but it doesn't work.

Here's my code:

foreach($html->find('a') as $element) {
    if (strpos($element->href, "/src/")){
    $a = $element->href;    
    $ht = "<img src=\"" . $a. "\" />\n";
    $arr = array($ht);
    $arr = array_unique($arr);
    foreach($arr as &$b) {
            echo $b;
        }
    }
}

Thanks for any help in advance!

share|improve this question

1 Answer

up vote 1 down vote accepted

You are not adding to an array, you are redefining $arr on every iteration. Try this:

$arr = array();
foreach($html->find('a') as $element) {
    if (strpos($element->href, "/src/")){
        $a = $element->href;    
        $ht = "<img src=\"" . $a. "\" />\n";
        $arr[] = $ht; 
    }
}
$arr = array_unique($arr);
foreach($arr as &$b) {
    echo $b;
}
share|improve this answer
Gives a lot of errors, all seem to be stemming from: Undefined variable: arr – AviateX14 Apr 9 '12 at 14:41
Code updated, $arr is now initialized at the top. – bfavaretto Apr 9 '12 at 14:42
This increases the amount of duplicates – AviateX14 Apr 9 '12 at 14:45
By which I mean, this happens: aviatex14.co.uk/apps/… – AviateX14 Apr 9 '12 at 14:51
My code (and your original code) was missing a closing }. Fixed now. From your link, it looks like 4chan is detecting you're trying to leech their images, and serving that standard logo instead. – bfavaretto Apr 9 '12 at 14:59
show 1 more comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.