PHP - array_push() & $array[] doesn't work?

Question

1. PHP function.

I've created validating function, here it is in shorter version:

function my_function($input) {
   $settings = my_source(); // function taht outputs a long array

   foreach ($settings as $setting) {
      $id = $setting['id'];  
      $foo = $setting['foo'];
      $option = get_option('my_theme_settings');

        if($foo == "bar") {
           $valid_input[$id] = $input[$id];
        }  

   } 

   return $valid_input; 
};

Basically it takes $input and saves it as $valid_input. When it gets new $input it overwrites the old #valid_inpu and so on.

I want to create an additional $valid_input[$id] array that will not overwrite itself, but just push new elements inside.

2. Array_push() that doesn't work.

So the new updated code will look like that:

function my_function($input) {
   $settings = my_source(); // function taht outputs a long array

   foreach ($settings as $setting) {
      $id = $setting['id'];  
      $foo = $setting['foo'];
      $option = get_option('my_theme_settings');

        if($foo == "bar") {
           $valid_input[$id] = $input[$id];
        } 

        else if($foo == "noupdate") { // it doesn't work
           $valid_input[$id] = array();        
           array_push($valid_input[$id], $input[$id]);
        } 

   } 

   return $valid_input; 
};

As mentioned in comment above - this doesn't work, input always overwrites the option, it creates an array but it always contains only one element that is being erased with the new one (I guess array_push should prevent that behavior, right?).

3. The same happens with $array[] =

function my_function($input) {
   $settings = my_source(); // function taht outputs a long array

   foreach ($settings as $setting) {
      $id = $setting['id'];  
      $foo = $setting['foo'];
      $option = get_option('my_theme_settings');

        if($foo == "bar") {
           $valid_input[$id] = $input[$id];
        } 

        else if($foo == "noupdate") { // it doesn't work
           $valid_input[$id][] = $input[$id];
        } 

   } 

   return $valid_input; 
};

Still it overwrites the old value of $valid_input instead of pushing an element.

Any ideas? Maybe there's something wrong with the code? This whole function a Wordpress callback for function called register_setting(), but I guess it's mostly PHP related as folks on WPSE can't help me.

4. EDIT

This does exactly what I want, but why point 3. doesn't work then?

    else if($foo == "noupdate") { // it doesn't work
       $valid_input[$id][] = 'something';
       $valid_input[$id][] = 'something_else';
       $valid_input[$id][] = 'something_else2';
    }

So you pass more than one $setting with the same $id. Have you tried debug-outputting $id and $foo inside the loop to check if it's not actually the data that leads to this behavior. I thought of a scenario where your $valid_input[$id] gets filled and the last $setting has $foo == "bar" and replaces your array with $input[$id]. Some example data for $settings would be helpful. — Basti, Mar 8 '12 at 21:34
Basti, well, I guess something went really wrong since every setting has different $id :> — Wordpressor, Mar 8 '12 at 21:54

Ray · Accepted Answer · 2012-03-08 21:55:52Z

up vote 1 down vote accepted

$valid_input[$id] needs to be set to array before you treat it as one.

$valid_input[$id] = array();
array_push(  $valid_input[$id], "some stuff");

Same deal with [] notation

$valid_input[$id] =  array();
$valid_input[$id][] =  "some stuff";

To check if the array has been declared, so this:

if(!is_array($valid_input[$id]){
   $valid_input[$id] =  array();
}

edited Mar 8 '12 at 21:55

answered Mar 8 '12 at 21:38

Ray
11.4k21029

But I'm setting them as arrays, at least in the first example, it doesn't change anything in both cases. – Wordpressor Mar 8 '12 at 21:44

You're trying to use them as multi dimensional arrays... the internal arrays are not being declared. Try adding the array declaration before the push or assignment. – Ray Mar 8 '12 at 21:48

I'm sorry but I don't exactly get what you mean. You are right, these are internal arrays, but I can't declare $valid_input[$id] as an array before foreach loop because it will create an array for all cases. And declaring it right before push/merging does nothing. – Wordpressor Mar 8 '12 at 21:52

see above on how to see if it's already initialized – Ray Mar 8 '12 at 21:56

Ray, still nothing, but check the update. Maybe, just maybe, there's something wrong with $input[$id]? – Wordpressor Mar 8 '12 at 22:01

show 1 more comment

b_dubb · Answer 2 · 2012-03-08 21:46:05Z

up vote 1 down vote

is it possible that you are trying to push a new value to the array with a key value that already exists? i would test for an existing key value in your array before trying to push a value/key pair to it. example:

if ( !isset( $arr[ $key ] ) ) {
  $arr[ $key ] = $value;
} else {
  echo " duplicate key value ";
}

answered Mar 8 '12 at 21:46

b_dubb
360518

b_dubb, nice try, but that's not the case :( – Wordpressor Mar 8 '12 at 21:55

1

still i don't see that you are testing for an existing key element in your array. you should test for that $arr[ key ] before trying to push new values to that $arr – b_dubb Mar 8 '12 at 21:57

b_dubb, thanks for the idea, of course I'll do that. – Wordpressor Mar 8 '12 at 22:07

add comment

Arash Milani · Answer 3 · 2012-03-08 21:29:02Z

up vote 0 down vote

The thing is that objects are passed as reference. you need to clone the objects before using the array_push function. here is a sample function that will clone an object:

function DeepCopy($ObjectToCopy) {
    return unserialize(serialize($ObjectToCopy));
}

then you can use it this way

array_push($MyObjectsArray, DeepCopy($MyObject));

answered Mar 8 '12 at 21:29

Arash Milani
1,9731121

$valid_input[$id] = array_push($valid_input[$id],unserialize(serialize($input[$id]))); returns nothing. – Wordpressor Mar 8 '12 at 22:06

@Wordpressor: You don't use array_push() like that - check the manual. array_push() returns an integer value of the number of elements that are now in the array. Doing it the way you did in your comment is just overwriting the array! – Crontab Mar 9 '12 at 14:34

add comment

Crontab · Answer 4 · 2012-03-08 21:34:10Z

up vote 0 down vote

Either array_push() or a variable used with the array append operator [] need to actually be an array or these won't work. Double check that whatever is in $valid_input[$id] is an array before doing array operations on the variable. Check by doing:

if (is_array($valid_input[$id])) {
    // your code
}

edited Mar 8 '12 at 21:34

answered Mar 8 '12 at 21:28

Crontab
4,988923

Crontab, they're both arrays. – Wordpressor Mar 8 '12 at 21:56

add comment

asked	2 years ago
viewed	1920 times
active	2 years ago

current community

your communities

more stack exchange communities

PHP - array_push() & $array[] doesn't work?

1. PHP function.

2. Array_push() that doesn't work.

3. The same happens with $array[] =

4. EDIT

4 Answers

Your Answer

Not the answer you're looking for? Browse other questions tagged php arrays push or ask your own question.

Hot Network Questions

current community

your communities

more stack exchange communities

PHP - array_push() & $array[] doesn't work?

1. PHP function.

2. Array_push() that doesn't work.

3. The same happens with $array[] =

4. EDIT

4 Answers

Your Answer

Sign up or log in

Post as a guest

Not the answer you're looking for? Browse other questions tagged php arrays push or ask your own question.

Related

Hot Network Questions