current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

I have some code I want to put into a JSON object ultimately. But first I want to create a javascript object and within that object add an array of values. Sounds simple enough but my approach seems wrong. First I create a basic object, the set a few fields. Lastly, iterate over a bunch of checkboxes and then, if one is checked at that value to an array.

At the last step I need to add that array to my object (myData) and then JSONify it.

Any ideas how I can do this, seems myData.push(filters); doesn't work...

Note that the object itself is not an array, I want to place an array IN the object.

       var myData = new Object();

        myData.deviceId = equipId;

        myData.dateTo = dateTo
        myData.dateFrom = dateFrom;
        myData.numResults = $("#numResults").val();
        var i=0;
        var filters = [];
        $('input[type=checkbox]').each(function () {
               if (this.checked) {
                   allData += $(this).val() + ",";
                    filters[i] = {
                        filterIds: $(this).val()
                    };
                    ++i;
               }
            });

        myData.push(filters);
share|improve this question
1  
Push is not for Objects, it's for Arrays –  The Wobbuffet Jan 15 at 23:01

3 Answers 3

up vote 0 down vote accepted

That's not how to add items to an Object, change

myData.push(filters);

to

myData.filters = filters;

Also, maybe change = new Object to = {}. There's no difference, but it's easier to read, because literal notation takes up less space.

Read more about Array.prototype.push

share|improve this answer
    
thanks man that worked. –  user3196063 Jan 15 at 23:06
    
@user3196063 Remember to eventually accept! –  The Wobbuffet Jan 15 at 23:07
up vote 0 down vote

Use push to add elements to the filters array. Use property assignment to add another property to the myData object.

    var myData = {
        deviceId: equipId,
        dateTo: dateTo,
        dateFrom: dateFrom,
        numResults: $("#numResults").val()
    };
    var filters = [];
    $('input[type=checkbox]').each(function () {
        if (this.checked) {
            allData += $(this).val() + ",";
            filters.push({
                filterIds: $(this).val()
            });
        }
    });

    myData.filters = filters;

BTW, don't use new Object() to create an object, use {}.

share|improve this answer
up vote 0 down vote

Remove the need for an extra array and i.

var myData = {}

myData.deviceId = equipId;

myData.dateTo = dateTo
myData.dateFrom = dateFrom;
myData.numResults = $("#numResults").val();
myData.filters = [];
$('input[type=checkbox]').each(function () {
    if (this.checked) {
        allData += $(this).val() + ",";
        myData.filters.push({
            filterIds: $(this).val()
        });
    }
});
share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.