current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I am unable to access a json value

{"phone": [
{
    "@attributes": {
        "type": "cell",
        "ext": ""
    }
}, "(123) 456 7890", {
    "@attributes": {
        "type": "work",
        "ext": ""
    }
}
]}

using the following JavaScript: psudo

for each phone line ...

console.log(["@attributes"].type);
console.log(this); 
console.log(["@attributes"].ext);

... end for

I expected the following output:

cell
work (123) 456 7890
share|improve this question
    
ur json is invalid –  diEcho Aug 26 '11 at 9:15
    
@diEcho.. sorry about the {} cut! –  tnt-rox Aug 26 '11 at 10:03

4 Answers 4

up vote 1 down vote accepted

actually your json structure is not perfect, so here is the solution for your desired output

var json = {"phone": [
{
    "@attributes": {
        "type": "cell",
        "ext": ""
    }
}, "(123) 456 7890", {
    "@attributes": {
        "type": "work",
        "ext": ""
    }
}
]};
 console.log(json['phone'][0]['@attributes'].type);
 console.log('<br/>'+json['phone'][1]);
 console.log('<br/>'+json['phone'][2]['@attributes'].type);

DEMO

share|improve this answer
up vote 1 down vote

since phone is an array, try this,

   for(var i=0;i<phone.length;i++)
     console.log(phone[i].["@attributes"].type);

Also surround your response with {, as it is currently an invalid json.

share|improve this answer
    
I'm trying to access the phone number. which is the 'value' of the 'this'. –  tnt-rox Aug 26 '11 at 9:15
1  
@ is not a valid character for an JavaScript identifier. You have to use the bracket notation and a string : console.log(phone[i]["@attributes"].type) –  RoToRa Aug 26 '11 at 9:17
    
@tnt your json is invalid. After writing a proper json, validate it from jsonlint.com –  Adeel Aug 26 '11 at 9:18
    
@RoTaRa thanks for correction. –  Adeel Aug 26 '11 at 9:19
    
@adeel the json comes from a php json_encode the origional xml is <phone type="cell" ext=""></phone> <phone type="work" ext="">(123) 456 7890</phone> –  tnt-rox Aug 26 '11 at 9:21
up vote 0 down vote

I'm pretty sure you can't start any object, associative array key or well anything with a non-alphanumerical character.

Also you have 3 calls to console and only two lines of expected output? What does console.log(this) output?

share|improve this answer
    
Actually you can. Object properties (there is no such thing as a "associative array" in JavaScript) can be any string. –  RoToRa Aug 26 '11 at 9:15
    
@dave thats what i'm trying to access it's the phone_number part of the json data. –  tnt-rox Aug 26 '11 at 9:17
    
@RoToRa I was just using the terminology. Aside from your JSON not being wrapped in {} I can't see console.log(this) working since this is out of scope unless you are running it through a loop. –  Dave Mackintosh Aug 26 '11 at 9:20
    
@dave yes not working being the operative word! –  tnt-rox Aug 26 '11 at 9:25
    
@tnt I understand that but this will not evaluate to anything, you need to change either the XML that PHP is using to output so that you have a better output or manually create your JSON string and output that instead. –  Dave Mackintosh Aug 26 '11 at 9:31
up vote 0 down vote

I think your phone array is quite messy because you have:

phone[0] === {'@attributes':...}
phone[1] === '(123) 456 7890'
phone[2] === {'@attributes':...}

Is that what you realy wanted to have there?

share|improve this answer
    
the json comes from a php json_encode the origional xml is <phone type="cell" ext=""></phone> <phone type="work" ext="">(123) 456 7890</phone> –  tnt-rox Aug 26 '11 at 9:22
    
hmm, so there should be some validation because you couldn't be sure on which index is the phone number or the object literal (attributes), am I right? –  muffir Aug 26 '11 at 9:27
    
thats it... any ideas? –  tnt-rox Aug 26 '11 at 10:02
    
only simple loop here in your next question: stackoverflow.com/questions/7203297/javascript-json-values/… –  muffir Aug 26 '11 at 10:48

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.