current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

I just made a quick little script with SQL query. Now when I go to phpmyadmin and execute

SELECT name FROM players WHERE online='1' ORDER BY name ASC

It outputs the desired players ( 0TheMonk, Player, Veeve )

But with PHP:

$query=mysql_query("SELECT name FROM players WHERE online='1' ORDER BY name ASC");
$query_array=mysql_fetch_array($query);
echo implode(',',$query_array);

It echoes: 0TheMonk,0TheMonk

Instead of: 0TheMonk,Player,Veeve

It always outputs the first player in the array, twice. What am I doing wrong? Thanks in advance.

share|improve this question
2  
Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. –  Kermit Mar 18 '13 at 19:48
    
mysql_fetch_array only returns one row. See the docs: php.net/mysql_fetch_array –  Rocket Hazmat Mar 18 '13 at 19:55

2 Answers 2

up vote 2 down vote

Use while loop

$query=mysql_query("SELECT name FROM players WHERE online='1' ORDER BY name ASC");
while($query_array=mysql_fetch_array($query))
{
    echo $query_array['name'].",";
}
share|improve this answer
    
Thank you, it actually helped, but now I have every player twice. 0TheMonk,0TheMonkPlayer,PlayerVeeve,Veeve That's even more weird O.o –  user2183800 Mar 18 '13 at 19:51
    
@user2183800 check my updated answer –  Sumit Bijvani Mar 18 '13 at 19:52
1  
Thank you so so so so much! <3 –  user2183800 Mar 18 '13 at 19:54
    
Glad to help you :) –  Sumit Bijvani Mar 18 '13 at 19:55
up vote 0 down vote

Try this : Almost same as Sumits answer.

$res    = array();
$query=mysql_query("SELECT name FROM players WHERE online='1' ORDER BY name ASC");
while($query_array=mysql_fetch_array($query))
{
    $res[]   = $query_array['name'];
}

echo implode(",",$res);

In this case there will not a extra , at the ens

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.