This is practically my first time using async in my code. I read about dos-and-donts but I wanted to get some feedback on what I've written.
I'm using a repository pattern and I'm inserting asynchronously into the database.
An explanation of the models involved: I have one DomainModel and three tblModels (tblModel1, tblModel2, tblModel3). tblModel2 and tblModel3 hold an ID from tblModel1. The DomainModel is made up of all three of the tblModels. I'm simplifying the domain to database mapping here because I'm focusing on feedback about the asynchronous calls.
Repository
public async Task<int> InsertAsync(tblModel1 tm1)
{
tm1 = db.tblModel1.Add(tm1);
await db.SaveChangesAsync();
return tm1.ID;
}
public async Task<int> InsertAsync(tblModel2 tm2)
{
tm2 = db.tblModel2.Add(tm2);
await db.SaveChangesAsync();
return tm2.ID;
}
public async Task<int> InsertAsync(tblModel3 tm3)
{
tm3 = db.tblModel3.Add(tm3);
await db.SaveChangesAsync();
return tm3.ID;
}
Manager
public async Task<bool> InsertAsync(DomainModel M)
{
try
{
await Task.Run(async () => {
var tm1ID = await repo.InsertAsync(M.tm1);
var tm2ID = await repo.InsertAsync(AddID(M.tm2,tm1ID));
var tm3ID = await repo.InsertAsync(AddID(M.tm3,tm1ID));
});
}
catch (Exception ex)
{
return false;
}
return true;
}
The method AddID(tblModel, int) is to get the point across that I'm adding the ID from tblModel1 after it's inserted into tblModel2 and tblModel3. In actuality, I do this but I map the DomainModel to completely new tblModels and during that process I add the IDs to tblModel2 and tblModel3. I believe the code above is representative of what I'm doing.
Please let me know if there is a better way for me to optimize these asynchronous inserts into the database. Thank you!
