<cfftp connection = "myConnection"
username = "#username#"
password = "#password#"
server = "#server#"
action = "open"
timeout = "500"
stopOnError = "Yes">
<cfloop index="i" from="1" to="#ArrayLen(ImagesArray)#">
<cfset slocal = "temp\" & ImagesArray[i] >
<cfset sremoteFile = "Images\" & ImagesArray[i]>
<cftry>
<cfftp
connection = "myConnection"
action = "getFile"
name = "uploadFile"
transferMode = "binary"
failIfExists = "false"
localFile = "#slocal#"
remoteFile = "#sremoteFile#" />
<cfcatch>
<cfabort>
</cfcatch>
</cftry>
<cfset files = files & "|" & slocalFile>
<cfset fileliste = fileliste & arFiles[i] & "|">
</cfloop>
<cfftp connection = "myConnection"
action = "close"
stopOnError = "Yes">
Take the 2-minute tour
×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
|
|||||||||
|
In my experience, FTP can use up a lot of network packets and CPU time just negotiating the starting and finishing of a single file. If there exists the option of having an archive uncompressed at the destination, I would suggest zipping the images into a single file for transport. To get even more performance for the end user making the CF request you could perform the FTP transfer in an asynchronous thread via cfthread. Launch the thread that zips and sends the file and let the user know that the data is on its way. Hope this helps, or at least inspires some new ideas. |
|||
|